ci: add rails 7.2 and 8.0 to the test matrix and bump some older dependencies#373
ci: add rails 7.2 and 8.0 to the test matrix and bump some older dependencies#373pkuczynski merged 19 commits intomasterfrom
Conversation
# Conflicts: # Appraisals # gemfiles/rails_6.1.gemfile # gemfiles/rails_7.0.gemfile # gemfiles/rails_7.1.gemfile
|
@Nuzair46 since you helped me with the other PR, maybe you can have quick look at this one too? I added Rails 8.x to the test matrix, but it fails. Not sure if this is CI issue or |
| .bundle | ||
| gemfiles/*.lock | ||
| gemfiles/bin | ||
| gemfiles |
There was a problem hiding this comment.
is this a good idea to ignore the whole gemfiles folder? should be just lockfiles only right?
There was a problem hiding this comment.
It's a good question, but since all those files are anyway auto generated by appraisal install I think it does not really make sense to keep it in the repo?
|
@Nuzair46 I merged this one for the sake of having newer Rails in test in the light of your PR, but I had to exclude jruby for rails >= 7.1 due the failing tests: https://github.com/rubyconfig/config/actions/runs/16206006758/job/45756326675?pr=373 Do you maybe know how to fix this? |
Will be fixed in #376 |
2 participants
No description provided.